TheChymera / neuralynx_nwb

Neuralynx to NWB converstion scripts (ideally to be upstreamed)
0 stars 0 forks source link

There should be no default path IMHO #1

Closed yarikoptic closed 1 year ago

yarikoptic commented 2 years ago

README talks about ~/.local/share/datalad and symlinking into it etc. I think the entry point (script, notebook, whatever) should take a specific path.

TheChymera commented 2 years ago

The path is parameterized: https://github.com/TheChymera/neuralynx_nwb/blob/3db29062e99e891fcfbe4d2a3f22004e3a9a4b2c/neuralynx_nwb/convert.py#L15

The rest of the instructions is just describing how I already laid it out for Manish in case he wants to look it up. I hope this clarifies it and avoids confusion: https://github.com/TheChymera/neuralynx_nwb/commit/0e7ff27fdf61dc1c2a6c6741ffe33cc6ea38a97a

Ofc eventually this would be a mandatory argument without any default.

TheChymera commented 1 year ago

closing this for now. It's pretty simple input logic which is currently just set up for convenience in development.