search

TheCodeCompany / wp-chargify

0 stars 1 forks source link

Wrong webhook #150

Open AlecArnold opened 3 years ago

AlecArnold commented 3 years ago

The subscription_product_change webhook is triggered when a user changes their subscription product and not when product details are edited. This could cause products to update locally with the details of a different product.

There isn't a webhook that triggers when product details are edited.

https://github.com/TheCodeCompany/wp-chargify/blob/846957f7db13f2f1c53c5144de46c936e7568c02/plugins/wp-chargify/includes/endpoints/base.php#L88

BronsonQuick commented 3 years ago

Interesting. The docs say this: "A successful change from an old product to a new product for a subscription. This webhook will fire for a product version change." for the subscription_product_change event. Sounds like I misinterpreted the version change or we need additional logic for the two possible types of data that's returned.