search

TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
246 stars 102 forks source link

Disabled element should not be focusable #1031

Open Lb-lea opened 5 years ago

Lb-lea commented 5 years ago

Hello, I noticed that the previous/next button on the b:Datatable pagination were still focusable when they where disabled. It is usually common practice to prevent focus on disabled elements (and the bootstrap datatable does unfocus its disabled elements). The answer is to tabindex="-1" these elements.

stephanrauh commented 5 years ago

Oops. You're right (like always!). However, I'm not sure if we can do something about this bug. It looks like a bug we've inherited from datatables.net, so their repository might be the right place to mention this bug. Plus, a cross-reference to us so we know when it's time to update our dependency from datatables.net.

However, this is only a first assessment. Maybe we can solve the bug ourselves easily.

Merci, et a bientôt Stephan

geopossachs commented 5 years ago

I would say this is a bug who is located in the third party library datatables.net

I take a look and would say this is the class there to change it https://github.com/DataTables/DataTablesSrc/blob/master/js/ext/ext.paging.js

But we can open an issue in the third party library. https://github.com/DataTables/DataTablesSrc/issues/146

geopossachs commented 5 years ago

fixed by commit https://github.com/DataTables/DataTablesSrc/commit/33219ff04498697da2c83b99a11d200e669e1cd3 - we are still wating on the next version of DataTables

stephanrauh commented 5 years ago

Whow - it was fixed yesterday, and you've already found it! :)