search

TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
246 stars 102 forks source link

Colreorder plugin is missing in DataTables CDN url #1100

Closed mtvweb closed 4 years ago

mtvweb commented 5 years ago

The can url is missing the column reorder plugin. the cr -part is missing in the cdn DataTables resource url

mtvweb commented 5 years ago

Additionally DataTables.min.js is included twice with different cdn values

geopossachs commented 5 years ago

hello @mtvweb that's wonderful that you want to support the project.

i would like to review your changes. It is possible to shorten the pull request to the central changes? (rebase; chery pick; ...)

mtvweb commented 5 years ago

Simply changed the cdn datasource to the current one

AddResourcesListener.addDatatablesResourceIfNecessary("https://cdn.datatables.net/v/bs/jszip-2.5.0/dt-1.10.20/af-2.3.4/b-1.6.1/b-colvis-1.6.1/b-html5-1.6.1/b-print-1.6.1/cr-1.5.2/fc-3.3.0/fh-3.1.6/r-2.2.3/rg-1.1.1/rr-1.2.6/sc-2.0.1/sl-1.3.1/datatables.min.css", "css"); AddResourcesListener.addDatatablesResourceIfNecessary("https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.1.36/pdfmake.min.js", "css"); AddResourcesListener.addDatatablesResourceIfNecessary("https://cdnjs.cloudflare.com/ajax/libs/pdfmake/0.1.36/vfs_fonts.js", "css"); AddResourcesListener.addDatatablesResourceIfNecessary("https://cdn.datatables.net/v/bs/jszip-2.5.0/dt-1.10.20/af-2.3.4/b-1.6.1/b-colvis-1.6.1/b-html5-1.6.1/b-print-1.6.1/cr-1.5.2/fc-3.3.0/fh-3.1.6/r-2.2.3/rg-1.1.1/rr-1.2.6/sc-2.0.1/sl-1.3.1/datatables.min.js", "js");

URLs are generated with the download page.

stephanrauh commented 4 years ago

@mtvweb @geopossachs I've merged the PR. Would one of you like to add a demo to the BootsFaces showcase? That'd be great!

Best regards, Stephan