Fix CSS for select with other field sizes

TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project

Apache License 2.0

247 stars 102 forks source link

Fix CSS for select with other field sizes #1119

Closed sebsoftware closed 4 years ago

sebsoftware commented 4 years ago

The select was rendered distorted in Safari, Chrome, Firefox on macos after the fixing #1090. The no longer set -webkit-appearance to menubutton-list is no longer overriding the line-height. This was set wrongly for field sizes other than md. Also long text was overlayed by arrow images.

Fixes TheCoder4eu/BootsFaces-OSP#1097

stephanrauh commented 4 years ago

It seems updating to Bootstrap 3.4.1 fixes the problem. Can you please verify if it works on the source I've just pushed to GitHub?

mtvweb commented 4 years ago

Still there. Just downloaded bootsfaces-1.5.0-20200429.204938-1.jar and modified selectOneMenu.xhtml from BootfacesWeb.xml second b:selectOneMenu to

<b:selectOneMenu value="#{selectOneMenuBean.type}" colMd="2" required="true" label="Select your car's type:" labelColMd="2" styleClass="car-class" field-size="sm">

stephanrauh commented 4 years ago

@geopossachs That's precisely what I did. Which browser are you using? Does the error occur without your IE bugfix #1090, too?

This is what it looks like on my Mac:

Brave (based on Chromium):

Safari (looks a bit odd on the right-hand side, but doesn't shift the text southward):

Firefox:

mtvweb commented 4 years ago

MacOS 10.14.6 Safari Version 13.1 (14609.1.20.111.8) Chrome Version 81.0.4044.129 (Offizieller Build) (64-Bit) Firefox 74.0 (64Bit)

stephanrauh commented 4 years ago

@mtvweb Oops, sorry for confusing you with Georg. Luckily, you've received my answer nonetheless.

I'm confused. We're running almost the same configuration. I'm running a slightly newer OS, but that shouldn't make much of a difference. Probably the bug is on my side, but I can't spot it. Just to be sure: open your developer tools and disable the cache in the network tab (if you haven't done so already).

You can also try the staging area of BootsFaces. It runs the latest changed I've committed. On my machine, it looks like this:

mtvweb commented 4 years ago

It seems to be that you have modified the b:selectOneMenu with select2 for testing. I've used the second one without select2.

stephanrauh commented 4 years ago

That sounds like one of the thing I'm always doing. But in this case, I don't think so. Mind you, after deliberately switching the second select box to "select2" it looks like so:

The most prominent difference being the arrow on the right-hand side of the select box.

Confused greetings :) Stephan