search

TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
247 stars 102 forks source link

add a check if a button is used in a grid layout #1122

Closed geopossachs closed 4 years ago

geopossachs commented 4 years ago

i think we need (" btn-block") if the dropButton is used in a grid layout

stephanrauh commented 4 years ago

Difficult to say. It's a breaking change. But it's likely that most people expect that behavior.

Is there any antidote if it really breaks the layout of an application?

geopossachs commented 4 years ago

my workaround in the current version

  <b:dropButton value="Änderungen speichern"
                                  look=**"success btn-block"**
                                  col-md="2" offset-md="8"
                                  drop="up" >
stephanrauh commented 4 years ago

Yeah, sure. Mind you, I've already merged your PR. So I wonder what to say to developers who relied on what we consider a bug. However, I suppose we get away with such a breaking change when publishing a new major version such as 1.5.0. It's not exactly semantic versioning, but it's close. :)

geopossachs commented 4 years ago

if the screen is tall, you won't see anything tall_without_bug

currently, if the screen to small, the button is too large small_with_button-text_overflow

with the bugfix, if the screen to small, the button is well but it exists a button-text cut small_with_button-text_cut