TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
247 stars 102 forks source link

#1020 add support for Date-Type by min/maxDate in dateTimePicker #1136

Closed geopossachs closed 4 years ago

stephanrauh commented 4 years ago

Do we have to modify the BootFaces.jsfdsl file, too?

I also wonder if the signature of the setter is OK. What happens when you call setMaxDate(String) with a date? Did I miss something?

While you're at it: should we support the new Java8 Date/Time API, too?

geopossachs commented 4 years ago

Do we have to modify the BootFaces.jsfdsl file, too?

It is possible to accept String and Date twice?

I also wonder if the signature of the setter is OK. What happens when you call setMaxDate(String) with a date? Did I miss something?

i have use and so i can set a Date()

While you're at it: should we support the new Java8 Date/Time API, too?

i would prefer Java8 Date/Time API in the next Version 1.6

stephanrauh commented 4 years ago

It is possible to accept String and Date twice?

That's the domain of languages like TypeScript. :)

I guess it should be possible to define two setters, one for each type. However, there's no easy fix for the getter. Probably it's best to simply use the least common denominator Object.