search

TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
246 stars 102 forks source link

Modals do not escape component clientId #138

Closed jbmb closed 9 years ago

jbmb commented 9 years ago

When using <b:modal> component, initializing javascript is generated. However, the clientId contained here does not escape special chars (e.g. ':'), there is an error in the javascript console, even in the bootsfaces showcase.

jbmb commented 9 years ago

I have a fix prepared, I'm gonna commit it in a while.

stephanrauh commented 9 years ago

Thanks. Whow, you even added a unit test!

May I ask why you removed the "fade" class? Is it unnecessary or wrong?

String styleClasses = "modal" + " fade";
stephanrauh commented 9 years ago

Successfully tested (see http://www.bootsfaces.net/BootsFacesWeb/bootstrap/modal.jsf).

jbmb commented 9 years ago

Sorry, I haven't commented the 'fade' thing - from my perspective, this class in undesirable. It enforces the fade effect even if I don't want it. However, it may be added via styleClass whenewer needed. Are you ok with this change?

stephanrauh commented 9 years ago

Yes, it's fine by me. But we have to document it because it's sort of a breaking change.

stephanrauh commented 9 years ago

Done: #143.