TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
246 stars 102 forks source link

some icons are not working in `<b:commandButton>` #146

Closed ahofmeister closed 9 years ago

ahofmeister commented 9 years ago

I got a datatable with editing entries: pencil-button to edit an item, minus-button to delete, plus-button to create and ok-button to save the edited item. The ok-icon does not work, properly?

iconsbf

As you can see, the icon is missing with following mark up:

<b:commandButton value="" iconAwesome="ok" rendered="#{jahrgang.editable}"
                            look="info" size="xs" ajax="true" update="@form"
                            action="#{adminKonfigurationJahrgang.speichereJahrgang(jahrgang)}">
</b:commandButton>

Just to compare (all of those are working, doesnt matter if pencil. minus or plus (see below)):

 <b:commandButton value="" iconAwesome="pencil/minus/plus"
                            rendered="#{!jahrgang.editable}" look="info" size="xs"
                            ajax="true" update="@form"
                            action="#{adminKonfigurationJahrgang.editiereJahrgang(jahrgang)}" />
yersan commented 9 years ago

BootsFaces is using Font Awesome v4.3.0. In that version ok icon is named check. Use check instead of ok and you should be able to see the correct icon:

<b:commandButton value="" iconAwesome="check"
                            rendered="#{!jahrgang.editable}" look="info" size="xs"
                            ajax="true" update="@form"
                            action="#{adminKonfigurationJahrgang.editiereJahrgang(jahrgang)}" />
ahofmeister commented 9 years ago

Oh, I did not know that, apperently. Thanks for the hint. It does work perfectly.

yersan commented 9 years ago

You're welcome !