TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
246 stars 102 forks source link

b:buttonGroup, b:button and tooltips - last button has no round corners #164

Closed vsvetoslavov closed 9 years ago

vsvetoslavov commented 9 years ago

Currently when buttons in a button group have tooltips, the last button in the button group does not have rounded corners. Digging a bit, I found that in bootstrap the definition for the last button in a button group is like '.btn-group .btn:last-child'. However this is not entirely correct, because BootsFaces renders a small script for tooltips after each component that has a tooltip set. The latter however doesn't always work. It is clearly visible in the examples that some of the tooltips are tooltips (like callouts) while others are plain titles - for example the datepicker's trigger button etc. etc.

It would be nice if the buttons don't lose their round corners when tooltip is set.

stephanrauh commented 9 years ago

That's a very surprising side effect. You've got sharp eyes!

vsvetoslavov commented 9 years ago

I noticed one more nasty effect with tooltips and button groups - if the tooltip is rendered in the same container (the default behavior), then buttons may get displaced because the div rendered between buttons affects the css styling a bit. Using a data-container seems to fix the problem.

stephanrauh commented 9 years ago

This issue seems to be fixed by both #165 and #166.

stephanrauh commented 9 years ago

The problem still exists because Bootstrap still accidentially counts the Javascript node as a widget node.

stephanrauh commented 9 years ago

Solved the problem by moving the JavaScript code into the button.