search

TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
246 stars 102 forks source link

form has height 0 #48

Closed stephanrauh closed 9 years ago

stephanrauh commented 9 years ago

Just saw this one on the staging showcase - one of the CSS rules you've changed recently seems to be important:

image

TheCoder4eu commented 9 years ago

For some reason inputText lost its enclosing form-group div...

stephanrauh commented 9 years ago

Oops - sounds like an unexpected effect of a change of mine.

TheCoder4eu commented 9 years ago

Have a look here:

https://github.com/TheCoder4eu/BootsFaces-OSP/commit/16eb146567400db678191d92cfbe29f98912d6ac#diff-ac3e1dc8a2df5358e9a98650782985c7

InputTextRenderer rows 89-91 the form-group now is rendered only if label is not null.

stephanrauh commented 9 years ago

Surprising effect... as far as I can see, form-group does nothing but adding a margin of 15px. Yet still, dropping it reduces the height of the form to zero pixels!

I reactivated the form-group and added it to b:selectOneMenu, too.