search

TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
246 stars 102 forks source link

Font Awesome loaded by default from CDN #686

Closed ggam closed 5 years ago

ggam commented 7 years ago

Font Awesome icons are loaded by default from CDN, in contrast to all other resources which are by default loaded from the Jar.

From what I see in the documentation, this seems unintended.

ggam commented 7 years ago

Also, when disabling loading from CDN via the context param, it doesn't load Awesome icons at all. Even when the b:iconAwesome component is used

ggam commented 7 years ago

My fault. It is explained on the Icons page.

Btw, what's the reason to not bundling it directly?

stephanrauh commented 7 years ago

The context parameter works as designed. But I think it's a bad design. Maybe we should deprecate the context parameter and replace it with another, less confusing parameter. For example:

    <context-param>
        <param-name>net.bootsfaces.fontawesome</param-name>
        <param-value>local</param-value>
    </context-param>

The values of the parameter could be local, CDNor none.

stephanrauh commented 5 years ago

Let's close the ticket after such a long time.