TheCoder4eu / BootsFaces-OSP

BootsFaces - Open Source Project
Apache License 2.0
246 stars 102 forks source link

Width of DataTable #822

Closed chsreedhar closed 5 years ago

chsreedhar commented 7 years ago

It seems that for <b:dataTable > width attribute is being set to some value like 1108px; based on window size, this value not changing when the browser resizes. Because of this fixed width responsive attribure of <b:dataTable > not working properly. But, in DataTables the width attribute is 100%

stephanrauh commented 7 years ago

The datatables of our showcase resize when the browser window gets smaller. There seems to be a minimum size (roughly 400-450 pixel), but that's probably caused by the content of the table.

image

stephanrauh commented 7 years ago

Can you try to find out where the fixed size comes from in your application? Alternatively, would you mind to check whether our showcase demos show the same behavior?

chsreedhar commented 7 years ago

Screen shot attached capture

stephanrauh commented 7 years ago

Do you use Patternfly? There's only one "980px" in the entire project. It's the container size of medium-sized containers in the Patternfly layout.

chsreedhar commented 7 years ago

Am using patternfly.min.css and patternfly.min.js by setting BootsFaces_THEME to custom and BootsFaces_USETHEME to false

chsreedhar commented 6 years ago

@stephanrauh to solve the issue set the width attribute of the table to 100%

<b:dataTable style="width:100%">

image

chsreedhar commented 6 years ago

@stephanrauh you may set style attribute style="width:100%" for table element.

stephanrauh commented 6 years ago

Thanks for the reminder. For some reason, I've missed your November message.

I just wonder how to implement your proposal. Of course we could generate style="width:100% into the HTML code. We could even guard it with a check examining the style attribute in the *.xhtml file. But there's no way we can guard against a width attribute in the CSS class.

So I recommend simply mentioning the issue in the showcase, documenting that adding style="100%" solves problems with certain themes. What's your opinion? Is that enough?

chsreedhar commented 6 years ago

@stephanrauh mention the issue in the showcase and document it.

stephanrauh commented 5 years ago

Good idea. Done!