<b:dataTable> breaks when using rendered on a column

RuslanVNikolov commented 7 years ago

Currently, I've noticed that when using rendered attribute on a or a this breaks the page with the following error: TypeError: i is undefined[Learn More] datatables.min.js.jsf:36:271 This causes the table's design to break. Is there a way to do hide a column without this happening? Maybe something I'm not using properly?

stephanrauh commented 7 years ago

Like so?

<b:dataTable value="#{carPool.carPool}" 
              var="car"
              widgetVar="myDataTableWidgetVar">
     <b:dataTableColumn value="#{car.brand}" />
     <b:dataTableColumn value="#{car.type}" rendered="false"/>
     <b:dataTableColumn value="#{car.color}" rendered="false"/>
     <b:dataTableColumn value="#{car.year}"  order="asc" rendered="false" />
     <b:dataTableColumn value="#{car.price}"  rendered="false"/>
     <b:dataTableColumn value="#{car.enginePower}" label="Engine Power (hp)" rendered="false" />
</b:dataTable>

It works fine on my machine. Only when I set rendered="false" on every column, there's an error message. Even so, it a different error message.

So what does your code look like exactly?

stephanrauh commented 7 years ago

@RuslanVNikolov I'll close the ticket now because I can't reproduce it. If you send us a reproducer, we'll happily have a look at it. It's just that I don't have a clue how to proceed because my tests didn't show any problems.

vsvetoslavov commented 7 years ago

Hi I confirm we have this problem (plus I work together with Ruslan). I did a little bit of investigation and noticed that there is a column list (something like columns: [null, null, null, ..., {orderable: false}] ) inside the generated javascript. Further investigation led me to the following lines inside DataTableRenderer class:

String orderable = column.getAttributes().get("orderable").toString();
if ("false".equalsIgnoreCase(orderable)) {
    if (dataTable.getColumnInfo() == null) {
        List<String> infos = new ArrayList<String>(dataTable.getChildren().size());
        for (int k = 0; k < dataTable.getChildren().size(); k++) {
            infos.add(null);
        }
        dataTable.setColumnInfo(infos);
    }
    List<String> infos = dataTable.getColumnInfo();
    String s = infos.get(index);
    if (s == null) {
        infos.set(index, "'orderable': false");
    } else
        infos.set(index, s + ",'orderable': false");
}

As you may notice, the array list size ignores the rendered attribute - which leads to a JS error. To confirm this finding I removed the orderable attribute of the only column that had it (the rest use the defaults for sorting) - when there was no columns definition, there was no JS error. @stephanrauh The sample you wrote above will not reproduce the problem, because you have no rendered column that has orderable="false" | dataType | customOptions | orderBy attribute. You can test with a configuration that has several columns, one with orderable="false" and another with rendered="false". I guess this behaviour might be observed also in all the above cases... We had the rendered property bound to a value from the controller, but I did my testing with static values and it still did break the datatable. I could pull the code and do the refactoring for this, but I'm not really sure what the correct workflow is for that, and how to do a "pull request" or whatever, so I'd rather wait, but if someone has the time to explain to me these details, I'll gladly contribute... :)