Dead Code in R.encodeColumn()

[stephanrauh]

R.encodeColumn() declares two variables that are never used and hence can be safely removed. The compilers optimizes them away, anyways :).

[TheCoder4eu]

I'll have a look and remove them, by the way did you already play with the proguard task?

[stephanrauh]

No, I didn't. I converted my fork of the project to Maven to simplify debugging. I didn't add the Proguard task to the maven file yet.

[TheCoder4eu]

In R.encodeColumn() I can see only a String s that is unused, am I missing something else? Thanks, Riccardo

On Sun, Nov 9, 2014 at 5:26 PM, Stephan Rauh notifications@github.com wrote:

No, I didn't. I converted my fork of the project to Maven to simplify debugging. I didn't add the Proguard task yet.

— Reply to this email directly or view it on GitHub https://github.com/TheCoder4eu/BootsFaces-OSP/issues/9#issuecomment-62308975 .

[stephanrauh]

There's also the StringBuilder in line 128:

StringBuilder append = sb.append(OFFSET+offset);

It would suffice to write

sb.append(OFFSET+offset);

[TheCoder4eu]

Men, you are right! That's true, I wonder how I can possibly have written this useless assigment... Thanks. Pushed to upstream.

On Sun, Nov 9, 2014 at 6:46 PM, Stephan Rauh notifications@github.com wrote:

There's also the StringBuilder in line 128:

StringBuilder append = sb.append(OFFSET+offset);

It would suffice to write

sb.append(OFFSET+offset);

— Reply to this email directly or view it on GitHub https://github.com/TheCoder4eu/BootsFaces-OSP/issues/9#issuecomment-62311989 .