TheCoder4eu / BootsFacesWeb

BootsFaces : the next gen JSF Framework Web Docs
Apache License 2.0
36 stars 32 forks source link

Images used on Carousel should be move to resources #40

Closed ggam closed 3 years ago

ggam commented 7 years ago

And loaded with the JSF resouce mechanism ()

stephanrauh commented 7 years ago

Why? What's the advantage of using the resource folder?

ggam commented 7 years ago

Just that we would show the JSF recommended way.

Don't know if there are any practical differences (maybe HTTP2 push? http://ridingthecrest.com/blog/2017/04/18/please-test-mojarra-2_3_1-with-server-push.html), but using would go through the JSF engine ("JSF Resource request", says the spec).

stephanrauh commented 7 years ago

Exactly. And sending images through the JSF engine is a lot slower than having the served fast by a caching Apache server (which is often in front of the application server).

I suggest we keep at least one "direct" demo while modifying the other demo. Thus, we test both approaches.

ggam commented 7 years ago

If caching is the only performance concern, can't it be solved directly by the OmniFaces resourceHandler and by configuring the application server? Or is the process itself so much slower?

El vie., 28 de abril de 2017 21:34, Stephan Rauh notifications@github.com escribió:

Exactly. And sending images through the JSF engine is a lot slower than having the served fast by a caching Apache server (which is often in front of the application server).

I suggest we keep at least one "direct" demo while modifying the other demo. Thus, we test both approaches.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TheCoder4eu/BootsFacesWeb/issues/40#issuecomment-298087746, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAucG6du0KyVRaD-onsI7fH71UxOKFLks5r0j9SgaJpZM4NL1Ox .

stephanrauh commented 7 years ago

AFAIK Apache is written in Assembly language or C (at least the performance critical parts). Plus, it's a common pattern to put a firewall between Apache and Tomcat. So the JSF resource handler is two servers farther away from the web. I never managed to measure the performance difference reliably, but I've seen a huge difference in at least one project.

ggam commented 7 years ago

Interesting, I've never really thought about that.

I think we should leave there as it is, perhaps with a comment explaining why we went that way.

After earching a little on the internet, seems like the only advantage of using graphicImage is when having the images on the same war.

El vie., 28 de abril de 2017 22:04, Stephan Rauh notifications@github.com escribió:

AFAIK Apache is written in Assembly language or C (at least the performance critical parts). Plus, it's a common pattern to put a firewall between Apache and Tomcat. So the JSF resource handler is two servers farther away from the web. I never managed to measure the performance difference reliably, but I've seen a huge difference in at least one project.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TheCoder4eu/BootsFacesWeb/issues/40#issuecomment-298093932, or mute the thread https://github.com/notifications/unsubscribe-auth/ACAucOki11fUa_AFzW_YzxnZbO-fqTavks5r0kZUgaJpZM4NL1Ox .

stephanrauh commented 7 years ago

IMHO, demonstrating both options is a good idea. As long as our showcase is our principal testing area, it's good to implement the same thing in different ways in order to detect regressions early.

geopossachs commented 3 years ago

work on this issue via commit 915c655106a27bfac72a95082ae4d2ea1b9e3ee1