search

TheCoderPal / terasoft-summer-reunited

Automatically exported from code.google.com/p/terasoft-summer-reunited
0 stars 0 forks source link

E3 : As a system, I should generate unique flow of items every new game according to certain conditions #14

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
As a system, I should generate unique flow of items every new game according to 
certain conditions

Original issue reported on code.google.com by hollaxy...@gmail.com on 25 Jul 2012 at 8:51

GoogleCodeExporter commented 9 years ago

Original comment by hollaxy...@gmail.com on 30 Jul 2012 at 8:12

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r13.

Added most of the implementation of the engine of generating items.

Original comment by hollaxy...@gmail.com on 31 Jul 2012 at 11:10

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r166.

Added implementation of generating gym item.

Original comment by hollaxy...@gmail.com on 7 Aug 2012 at 10:54

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r220.

Implemented harder engine + cleaning code

Original comment by hollaxy...@gmail.com on 14 Aug 2012 at 2:27

GoogleCodeExporter commented 9 years ago 
remove unused usings
rename ItemsList to itemsList
too many repeated if conditions the code looks ugly replace them with switches
instead of if counter==0 else if counter ==1.. 2 ... 3 etc...
same for the inside if conditions if i=1/2/3/4/5/6/7/8/9...

Original comment by khaled.osmaan on 14 Aug 2012 at 9:49

GoogleCodeExporter commented 9 years ago 
At the time you posted it ,i was committing them :)

Actually C# does not allow switch statements for ranges.I like to keep my work 
uniform thats why i will not sometimes write switch and sometimes write if 
condition because no ranges in same parts "this is the one which will look ugly"

+ i am writing them in good way :)

Original comment by hollaxy...@gmail.com on 14 Aug 2012 at 10:10

GoogleCodeExporter commented 9 years ago 
I checked the if conditions most of them were equality checks, the range ones 
you can do them with if conditions as you wish, but yes switch(i){case:0 case:1 
default etc...} looks way better than if(i=0) if(i=1) else... specially with 
all these cases and if conditions

Original comment by khaled.osmaan on 14 Aug 2012 at 10:15

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r250.

Added new good and bad items in engine.

Original comment by hollaxy...@gmail.com on 15 Aug 2012 at 10:16

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r304.

Fixed some implementation issues

Original comment by hollaxy...@gmail.com on 17 Aug 2012 at 8:05

GoogleCodeExporter commented 9 years ago 
Implementation:
Randomize method.. you can randomize an array of strings using Array.OrderBy( x 
=> random.Next()).ToArray(); just one line. 
Code is a bit hard to understand thats why I have no further comments.

Original comment by vendett...@gmail.com on 17 Aug 2012 at 8:49