Open GoogleCodeExporter opened 9 years ago
This issue was updated by revision r46.
Added class SkeletalCommonExtensions.cs from Coding4Fun project.
Added methods to class Kinect to return hand position.
Original comment by vendett...@gmail.com
on 2 Aug 2012 at 10:31
This issue was updated by revision r56.
Uploaded completed class button
Original comment by vendett...@gmail.com
on 3 Aug 2012 at 12:05
This issue was updated by revision r57.
Slight modification for better drawing
Original comment by vendett...@gmail.com
on 3 Aug 2012 at 12:06
This issue was updated by revision r58.
Added HandCursor
Original comment by vendett...@gmail.com
on 3 Aug 2012 at 12:28
This issue was updated by revision r59.
updated solution
Original comment by vendett...@gmail.com
on 3 Aug 2012 at 12:31
This issue was updated by revision r60.
fixed compile error
Original comment by vendett...@gmail.com
on 3 Aug 2012 at 1:06
This issue was updated by revision r80.
added content proj file
Original comment by vendett...@gmail.com
on 3 Aug 2012 at 8:28
This issue was updated by revision r81.
added new initialize method that takes more parameters
Original comment by vendett...@gmail.com
on 3 Aug 2012 at 8:39
This issue was updated by revision r106.
added letter buttons and images
Original comment by vendett...@gmail.com
on 5 Aug 2012 at 4:11
This issue was updated by revision r107.
updated some screens according to screen manager.
Original comment by vendett...@gmail.com
on 5 Aug 2012 at 4:16
This issue was updated by revision r133.
fixed shirin issues
Original comment by vendett...@gmail.com
on 6 Aug 2012 at 11:40
This issue was updated by revision r189.
Added hand in InstructionsScreen and LosingScreen
Original comment by vendett...@gmail.com
on 7 Aug 2012 at 8:21
This issue was updated by revision r191.
Increased CLICK_TIME_OUT
Original comment by vendett...@gmail.com
on 7 Aug 2012 at 8:57
This issue was updated by revision r214.
fixed bug of hand in x position
Original comment by hollaxy...@gmail.com
on 9 Aug 2012 at 11:33
This issue was updated by revision r216.
fixing bug
Original comment by vendett...@gmail.com
on 12 Aug 2012 at 7:35
This issue was updated by revision r217.
fixing bug
Original comment by vendett...@gmail.com
on 13 Aug 2012 at 9:35
This issue was updated by revision r218.
fixing bug
Original comment by vendett...@gmail.com
on 13 Aug 2012 at 9:54
This issue was updated by revision r219.
fixing bug
Original comment by vendett...@gmail.com
on 13 Aug 2012 at 9:59
class button
"private int TextureWidth, TextureHeight;"
variable names shouldnt start with a capital letter, same for BoundingRectangle
and TextureBoundsSet
add the parameters you take in the initialize method in the constructor instead
and leave the initialize method parameter free, use screenmanager attributes
instead of taking them as parameters, loadcontent shouldnt take any parameters,
draw should take gameTime as a parameter instead of spritebatch I already sent
a mail about this
Joint rightHand = kinect.GetCursorPosition();
Point handPoint = new Point((int)rightHand.Position.X,
(int)rightHand.Position.Y);
use vars
class HandCursor
Samething as class Button
remove unused using statements
remove attributes screenwidth and screenheight from the kinect class
constructor it irrelevant
take it in the handcursor constructor instead or wherever you need it
Initialize method should not take any parameters, take the kinect from the
constructor
LoadContent shouldnt take any parameters, use screenmanager attributes
Joint RightHand = kinect.GetCursorPosition(); use var
replace spritebatch in draw method with gametime..
call base methods...
Original comment by khaled.osmaan
on 14 Aug 2012 at 9:27
1. Done
2. No. Why would I do that ?
3. No. Retard head this isnt a screen.. its not associated with a screen
manager... and nothing says loadcontent shouldnt take any parameters or so..
Its just a method.. and it happens to be with the same name as XNA's method.
4. Explain the usage of vars.
5. Bleh.
6. No, I need them in kinect... check getcursor method.
7. No. Retard head this isnt a screen.. its not associated with a screen
manager... and nothing says loadcontent shouldnt take any parameters or so..
Its just a method.. and it happens to be with the same name as XNA's method.
8. Same as above.
9. ''
10. No.
11. No.
Original comment by vendett...@gmail.com
on 15 Aug 2012 at 2:04
This issue was updated by revision r237.
implementation review
Original comment by vendett...@gmail.com
on 15 Aug 2012 at 2:06
its a convention for god sake... stop arguing just for the sake of it...
same thing again ... graphics attributes shouldnt be passed as parameters in
your methods
vars are used for obvious object references like for example screenmanager
screen = new ScreenManager(), instead it should be var screen = new
ScreenManager()
I dont know find a cleaner way then, all I know is a kinect class doesn't need
screenwidth and height attributes in its constructor, use them from the
screenmanager or whatever
enta 7or ana 3amalt ely 3alaya 3amatan...
Original comment by khaled.osmaan
on 15 Aug 2012 at 6:12
ok let me explain this once and for all... your object drawing could change
according to gametime thats why draw methods take as a parameter gametime, even
if you dont need it you shouldn't remove it, the sprite batch shouldnt be
passed there either in fact, you dont need it, use the one from the screen
manager like the whole project is working... intialize method and load content
shouldnt take any parameters either, thats where you define your variables and
load the textures you already predefined... if your class needs something like
kinect for example take it in the constructor, thats how we know your class
depends on kinect... in fact you dont even need to because there's an instance
of kinect in the screenmanager and what I just said is irrelevant to screens,
its anything you draw even if it was a string. I explained the usage of vars in
another issue, im not good at explaining if you still dont get it just google it
Original comment by khaled.osmaan
on 15 Aug 2012 at 6:42
Conventions set by who ? enta elly 7afez mesh fahem -_-
ana mosta3ed ageblak tons of games or projects online done by microsoft or
whoever.. and they do exactly what i did .. btw i can never access spritebatch
or contentmanager or anything else from a class other than a gamescreen unless
theyre passed :) and if you dont like screenwidth and screenheight in the
constructor.. suggest another way else ... theyre gonna be here.. i find it
relevant :)
Original comment by vendett...@gmail.com
on 15 Aug 2012 at 2:23
the hand is too smooth it steers too much, also try moving your hand in a
circular way or moving it vertically, its kinda weird
Original comment by khaled.osmaan
on 17 Aug 2012 at 10:52
Original issue reported on code.google.com by
vendett...@gmail.com
on 26 Jul 2012 at 1:19