search

TheCoderPal / terasoft-summer-reunited

Automatically exported from code.google.com/p/terasoft-summer-reunited
0 stars 0 forks source link

As a User,I can choose an avatar by swiping my hand across the avatar select screen. #51

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Story Description:
1.Implement the screen
2.add the textures needed for screen design
3. switch to next avatar using swipe hand kinect gesture

Original issue reported on code.google.com by khaled.osmaan on 27 Sep 2012 at 2:18

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r357.

status inProgress
added basic implementation of the screen

Original comment by khaled.osmaan on 27 Sep 2012 at 2:21

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r358.

Added hand and button

Original comment by khaled.osmaan on 27 Sep 2012 at 7:10

GoogleCodeExporter commented 9 years ago

Original comment by khaled.osmaan on 27 Sep 2012 at 7:16

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r373.

Added arrows, background image and temporary avatars

Original comment by khaled.osmaan on 28 Sep 2012 at 9:35

GoogleCodeExporter commented 9 years ago 
Imp review : 
1)instance variables having same type to be written together in one line like:  
private int screenWidth,screenHeight,...

2)There is already default constructor so why you overwrite it by empty one ? 
,please remove this : public SettingsScreen() { }
==
Note :The design of the page is very very bad,please fix it and choose suitable 
background.
http://i.imgur.com/OepUx.jpg

Original comment by tamer.na...@gmail.com on 5 Oct 2012 at 12:40

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r399.

did the notes considering implementation, will change the UI design of the 
screen later

Original comment by khaled.osmaan on 7 Oct 2012 at 1:30

GoogleCodeExporter commented 9 years ago 
Review :
1. Add a condition to this line if(Constants.isSwappingHand) 3shan mayeb2ash 
beyswap f ay 7eta fel screen w el avatar yet3'ayar
2. There are no braces surrounding the if i just mentioned.
3. The logic itself is wrong. You should have just an index pointing to the 
current avatar in your array and when he swipes his hand.. increase that index 
and check if its 4 .. set it to 0 ... w currentAvatar = avatars[index]; 

Apart from these notes.. good job
@Tamer.. what review is this ?! ..

Original comment by vendett...@gmail.com on 8 Oct 2012 at 2:36

GoogleCodeExporter commented 9 years ago 
this issue was updated by r403

Original comment by khaled.osmaan on 9 Oct 2012 at 6:12

GoogleCodeExporter commented 9 years ago 
Scenario review : 

Once i call setting screen ,i get this exception ,settings screen not showing :

http://i.imgur.com/4xk1r.png

Original comment by tamer.na...@gmail.com on 11 Oct 2012 at 5:10

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r404.

added line currentAvatar = avatars[0]; to fix the exception

Original comment by khaled.osmaan on 11 Oct 2012 at 9:52

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r406.

edited the Vector2 avatarPosition values to be exactly in between the arrows

Original comment by khaled.osmaan on 11 Oct 2012 at 10:00

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r408.

Changed button position, background and added some text

Original comment by khaled.osmaan on 13 Oct 2012 at 6:10