search

TheCodex6824 / ThaumcraftFix

GNU General Public License v3.0
8 stars 3 forks source link

Unnatural Hunger > Famished #11

Closed IcarussOne closed 4 months ago

IcarussOne commented 4 months ago

Renames the Unnatural Hunger effect to Famished, it still fits the effect because the definition is "extreme hunger". This was done to prevent the name from overlapping with the GUI because of how long it is. effect

TheCodex6824 commented 4 months ago

We can rename it if we really have to, but it would be nice to keep it the same so people don't get confused. Give this a try:

  1. Put #PARSE_ESCAPES on the first line of the lang file
  2. Try making the value Unnatural\nHunger (note the \n there)

If that renders correctly, then I think we should use that. Otherwise, renaming it is probably the simplest option.

IcarussOne commented 4 months ago

Hmm I've tried doing that and made sure #PARSE_ESCAPES is included, but it results in this.

effect

xJon commented 4 months ago

I will say, extreme hunger is not quite same as unnatural hunger, and doesn't make as much sense in-game with rotten flesh.

IcarussOne commented 4 months ago

Could also rename it to Unhunger like the lang key implies, it also wouldn't be as confusing.

TheCodex6824 commented 4 months ago

"Unhunger" might not be a bad name, although I think the lang key is just a shorter version of "unnatural hunger" and didn't mean to make a new term for it. The new name should ideally communicate that you can't help it by eating normal food, although I thought there was some text that appeared if you tried to eat normal food so at least the name isn't the only indicator.

IcarussOne commented 4 months ago

Checked on what would be the best way and I thought Unhunger was the best name for it when it comes to fitting with what the effect does while not being too long.

TechnoMysterio commented 4 months ago

There should be text that appears when you eat the wrong type of food, though of course I haven't checked to see if that still works in TC6. Unhunger does sound like a very good shorthand though, so I'd opt for that myself.