Resource fixes and tweaks

TheCodex6824 / ThaumcraftFix

GNU General Public License v3.0

5 stars 3 forks source link

Resource fixes and tweaks #5

Closed IcarussOne closed 2 weeks ago

IcarussOne commented 2 weeks ago

This PR should fix several issues with Thaumcraft's resources that I know of, which are all mentioned in #3.

Void tools now have a darker handle to fit with the void theme.
Several armor item sprites have had their positions centered.
Scaled up the gauntlet model so it doesn't look weird with skin layers and because I just think it looks cooler (works with other addons outside of Augmentation).
Removed the purple 'C' icon from creative only items (mainly the flux sponge) to be consistent with Thaumic Augmentation.
Fixed Primal Crusher and Triple Meat Treat not having animations like in previous Thaumcraft versions.
Fixed Redstone Inlays having a weird white and black border around them when placed.
Fixed the 'runicshieldcharge' sound event not playing because of a typo in the sounds.json.

IcarussOne commented 2 weeks ago

Also did a PR for Augmentation to have the same changes here.

TheCodex6824 commented 2 weeks ago

Thanks for contributing! Most of the changes look good, my only concern is that the gauntlet model now has clipping issues with robes: robes

Not sure what the best thing to do here is, without the gauntlet becoming comically large. I'll try to think of a way to stop that skin layer clipping, as I agree it's a bit ugly.

Btw - if you try to put the resources in the mod to look at them, rebase / merge latest main as I had to fix a resource loading issue. If you're just using resource packs for testing, you don't need to worry about it.

IcarussOne commented 2 weeks ago

Indeed an unfortunate side effect! One thing that you could probably try is have the old gauntlet size when wearing robe sets (or a configurable list of armor sets).

TheCodex6824 commented 2 weeks ago

Indeed an unfortunate side effect! One thing that you could probably try is have the old gauntlet size when wearing robe sets (or a configurable list of armor sets).

I'm going to think about it a bit more, but something like that would work. I also wonder if I could have the model dynamically scale itself to fit as tightly as possible around the user's arm - that would have it fit more nicely on slim arm player models as well. I don't know if that will cause more issues though...

IcarussOne commented 2 weeks ago

Both ways would be worth trying out, I'd say go with what you feel like it's best! :)