search

TheCodex6824 / ThaumcraftFix

GNU General Public License v3.0
8 stars 4 forks source link

Add Improved/Updated Research Images #7

Closed TechnoMysterio closed 3 months ago

TechnoMysterio commented 3 months ago

As per title, this should replace Thaumonomicon images with ones that aren't horrendously outdated, and also fixes up the vis crystal preview image with one that has them correctly coloured.

First PR I've done in a while, so do make sure I've done everything properly.

TheCodex6824 commented 3 months ago

The PR itself looks good, but when you look in the book ingame does the infusion image appear for you? It should be on the last page of the infusion entry (the spiky entry after the one that gives essentia banners). It looks like there is a research entry parsing bug that is preventing the image from showing up, but I want to make sure someone else sees it too before I fix it.

If you want to actually see the image ingame, you can work around the bug by copying the en_us.lang text for that page but adding a space at the end past the </IMG> (yes, really). You don't need to PR this though - I would add a code fix to fix the issue for all research.

TechnoMysterio commented 3 months ago

Checked the book entry for infusion, and no I cannot see the altar image at the end of the Infusion research entry. Huh, never noticed that before.

TheCodex6824 commented 3 months ago

Alright, I'll fix that issue in code then. Like I said the PR itself is good though, so thanks!