TheCodex6824 / ThaumicAugmentation

A Thaumcraft addon for Minecraft 1.12 that tries to add new content that would fit in with the base mod.
https://minecraft.curseforge.com/projects/thaumic-augmentation
GNU Lesser General Public License v3.0
40 stars 31 forks source link

Incompatibility with Electro-Magic Tools Classic #376

Open xJon opened 5 months ago

xJon commented 5 months ago

First reported over https://github.com/kappa-maintainer/ElectroMagicToolsClassic/issues/2, when Thaumic Augmentation is installed, these icons of EMTC's section (representing the various custom Goggles & Boots) are not rendered in the Thaumonomicon: image

Without Thaumic Augmentation: image

Any idea what could be causing this? Thank you!

TheCodex6824 commented 5 months ago

Do the items render normally in the inventory when TA is installed? What about other armor items in the thaumonomicon?

My first guess would be morphic armor breaking the rendering for some reason - try adding exceptions for these items to the TA config.

xJon commented 5 months ago

Indeed they render fine in the inventory with TA installed. What do you mean about other armour items in the Thaumonomicon? EMTC also offers wings which render fine, but I'm not sure if they count as armour: image

Oh - I added them into the config and they seem to render again! image image

xJon commented 5 months ago

Does adding those pieces to MorphicArmorExclusions mean the player can't wear them whilst looking like something else, or can't wear something whilst looking like them (or both)?

TheCodex6824 commented 4 months ago

Does adding those pieces to MorphicArmorExclusions mean the player can't wear them whilst looking like something else, or can't wear something whilst looking like them (or both)?

It means the player won't see the corresponding item model for the item in their inventory. When actually wearing the armor, the player model will have the correct armor, it's just the inventory icon that will be incorrect.

The way morphic armor works for the items is that it replaces the models of all armor item models with a wrapper model that checks if it is morphic armor or not and does special behavior with that. That config option is disabling the wrapper model from being applied to whatever items are specified in it. The actual armor rendering on the player is handled through an event, so I don't need to go replacing models.

If you give me a list of items that aren't rendering properly, I can take a look at if it's a TA bug. If I can't fix it, I can at least add them to the default config.

xJon commented 4 months ago

I see. Here's a list:

        welectromagic:itemelectricgoggles
        welectromagic:itemnanogoggles
        welectromagic:itemquantumgoggles
        welectromagic:itemelectricboots
        welectromagic:itemnanoboots
        welectromagic:itemquantumboots

(https://github.com/kappa-maintainer/ElectroMagicToolsClassic/commit/c4bd3ad5e8d0109049680fd10793d43e38070945 already adds them to the default config) Thank you!