search

TheCodez / dynamic-occupancy-grid-map

Implementation of "A Random Finite Set Approach for Dynamic Occupancy Grid Maps with Real-Time Application"
MIT License
281 stars 39 forks source link

[WIP] Add metric system #59

Closed TheCodez closed 4 years ago

TheCodez commented 4 years ago

Add basic metric system. Currently this doesn't handle computing metrics for different targets, which could be added later.

https://github.com/TheCodez/dynamic-occupancy-grid-map/issues/23

TheCodez commented 4 years ago

@cbachhuber for some reason I can't add you as a reviewer.

cbachhuber commented 4 years ago

Hmm, I don't know why you can't do this :thinking:

Let me check this (and review) in the evening ;)

cbachhuber commented 4 years ago

Maybe you can only request reviews from repository collaborators. You could try to add me as collaborator (see collaborator rights; maybe you could reduce my rights as collaborator, I don't need all of those) or you can keep requesting reviews manually from me, I leave that to you :+1:

TheCodez commented 4 years ago

I think I'll stick to cc'ing you, you'll get a notification anyways :)

TheCodez commented 4 years ago

Addressed your feedback 👍

cbachhuber commented 4 years ago

Looks good to me :+1:

Why are 5 checks running on this PR? :laughing: Maybe we need to adapt the workflows for format and ubuntu to also run only on master, like the windows workflow.

TheCodez commented 4 years ago

Just to be sure :laughing:

Fixed this 👍

TheCodez commented 4 years ago

FYI, this is ready to merge once I add some basic tests :)