search

TheComamba / UnKenny

A FoundryVTT module providing NPCs with artificial intelligence.
MIT License
2 stars 5 forks source link

MidiQoL Conflict #88

Closed wardmanm closed 5 months ago

wardmanm commented 5 months ago

Foundry V12.327 Unkenny V1.0.3 MidiQoL V11.4.37

Issue: If MidiQoL is enabled Unkenny no longer finds actor alias in chat and does not respond.

Example: image image

Midi QoL Settings attached. fvtt-midi-qol-settings.json

TheComamba commented 5 months ago

Oopsie. As a first hunch this may be related to #90. We will investigate.

TheComamba commented 5 months ago

I recant my hunch and will properly start investigating now. :D

TheComamba commented 5 months ago

I figured out what was going on. @wardmanm The conflict will be fixed with the next release, which I hope to publish in a few minutes. @KingphilAusti The people from MidiQol had the same bad idea we had: Overwriting the ChatMessage class. Only they do it twice, once on the init hook, and once on the setup. My quick fix is that we call our function in the setup hook instead of the init hook. I think this only works because "Unk" is after "Midi" in the alphabet. Their ChatMessage overwrite does not check if there is any other class currently set, but simply overwrites the DnD5e class. I'll drop them an issue asking them to adopt a design similar to ours.

TheComamba commented 5 months ago

@wardmanm Done. Thanks for bringing this to our attention. :)

wardmanm commented 5 months ago

Awesome, great work!