fix(types) Select, Breadcrumbs, ExpansionPanel slot type and VirtualList type

TheComputerM / svelte-materialify

A Material UI Design Component library for Svelte heavily inspired by vuetify.

https://svelte-materialify.vercel.app

MIT License

622 stars 83 forks source link

fix(types) Select, Breadcrumbs, ExpansionPanel slot type and VirtualList type #228

Closed AngelRionCervi closed 3 years ago

AngelRionCervi commented 3 years ago

I didnt add the VirtualList export in index.d.ts since it's supposed to be unavailable for now. If I forgot any slot types, let me know !

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/HtKB7a55Jo5uv6WpaM5QLdtA9C57
✅ Preview: https://svelte-materia-git-fork-angelrioncervi-fix-types-some-sl-ed44a3.vercel.app

Florian-Schoenherr commented 3 years ago

Thank you for the types help! That's cool, is it related to ts in markup? Or where do the $$slot_def types get used?

AngelRionCervi commented 3 years ago

I'm not too sure given the lack of documentation about this part of svelte. But I think it does types checks on the slots props and it does solve this issue :