search

TheComputerM / svelte-materialify

A Material UI Design Component library for Svelte heavily inspired by vuetify.
https://svelte-materialify.vercel.app
MIT License
623 stars 85 forks source link

#230 #238

Closed vladblindu closed 3 years ago

vladblindu commented 3 years ago

Fixed #230 css breakpoints overrides

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/2aFJQugR99BAKrkSGW21vkUommHk
✅ Preview: https://svelte-materialify-git-fork-vladblindu-master-thecomputerm.vercel.app

Florian-Schoenherr commented 3 years ago

@vladblindu you could've asked and waited, the PR problems might have been due to first contributors needing permission, so it would've worked probably 😄 (before you changed the imports) Sorry from our end, too. I've seen the message from TCM on the other PR, I guess you can still wrap it in your own component.

Now the only thing you need to do is, run yarn lint:fix from project root, see this. (lint:fix will let the linter fix it by itself) With svelterial, I expect the linter to kick in automatically or something.

vladblindu commented 3 years ago

I can't thank you enough for your patience. It's ok, I run the lint:fix and it was successful (exit code 0). Please bare with me. I'll close this pr and give it another try if you don't mind. I could, very well work with my own fork, but after such a struggle, believe me, I need to see this finally happening. :)

Florian-Schoenherr commented 3 years ago

you couldv'e commited this here xD well I'll merge the other one 👍