search

TheComputerM / svelte-materialify

A Material UI Design Component library for Svelte heavily inspired by vuetify.
https://svelte-materialify.vercel.app
MIT License
622 stars 84 forks source link

fix(Textarea): Fix label not being reactive (#247) #248

Closed V-ed closed 3 years ago

V-ed commented 3 years ago

This also makes the Textarea more in line with the TextField component

I also fixed autogrow not being updated if value is dynamically updated to a big value, see comments

REPL that shows issue(s) : https://svelte.dev/repl/1154fe4b3434494b88c2e1cf35960c76?version=3.38.1

Closes #247

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/86c5rL9h5HupDEDMyNyNzpL7jTMy
✅ Preview: https://svelte-materialify-git-fork-v-ed-patch-2-thecomputerm.vercel.app

V-ed commented 3 years ago

Also, since I was testing with another commit for the changes to the autogrow property, this would require a squash and merge instead of simply merging @Florian-Schoenherr

V-ed commented 3 years ago

ah, the vercel is broken right now, let me see what's the error

edit : fixed, but autogrow doesn't work

edit 2 : fixed, but setting value to '' or removing all text with ctrl A + delete does not update the grow value

edit 3 : should be all fixed!

V-ed commented 3 years ago

Sorry about all the individual commits btw, I really should get a dev build eventually on my local machine, but with svelterial coming up I think I'll wait 😅