search

TheComputerizer / Music-Triggers

This is a Minecraft mod that will allow you to set the music based on in game triggers
27 stars 6 forks source link

[1.12.2] Heavily modded instance doesn't load #158

Open Foreck1 opened 11 months ago

Foreck1 commented 11 months ago

The game crashes when launching in a modded instance at mods/thecomputerizer/theimpossiblelibrary/client/render/Renderable

Using theimpossiblelibrary-1.12.2-0.3.0 and musictriggers-1.12.2-6.3.1 plus all the other mods detailed in the provided logs crash-2023-12-24_17.43.22-client.txt

latest.log

TheComputerizer commented 7 months ago

So the actual crash here is this

Duplicate Mods:
    rotntweaker : C:\Users\Foreck\AppData\Roaming\PrismLauncher\instances\Testos\.minecraft\mods\RotN-Tweaker-0.0.1.jar

and let me explain why it blames MT/TIL here.

When the game crashes during startup, Forge will almost always try to do a soft crash where it display it's error screen and lists potential mods to blame. If this crash happens during the Loading, Constructing, or PreInitialization phases forge will also force the audio system to load (which normally isn't loaded until after other resources) so the music plays and the GUI click sound can be heard.

Music Triggers expects other resources to be loaded by the time sounds are, so when something crashes during startup and forge tries to load the error screen it will crash again and blame the Renderable class from TIL. Specifically, MT utilizes a mixin into the MusicTicker class in order to stop the vanilla music from playing which in turn loads ChannelManager which loads Renderable.

To see the actual reason for the crash you can look at the log above the crash report section and above all of the sound events & sound files being loaded.

This will be fixed in 7.0 but I won't be able to push a small fix before that since I already spend all my free time working on 7.0

Hlwyefeng commented 5 months ago

I see. Looking forward to the 7.0 version of 1.12.2 fixing it.