search

TheCre8r / WME-BackEnd-Data

3 stars 6 forks source link

Gas Prices [Italy] #24

Closed giovanni-cortinovis closed 3 years ago

giovanni-cortinovis commented 4 years ago

I've added support for Italian GS Prices in this fork https://github.com/giovanni-cortinovis/WME-BackEnd-Data

TheCre8r commented 4 years ago

I added your code with the latest version. Will you please test the changes?

giovanni-cortinovis commented 4 years ago

We didin't find any issue with latest version. Thank you!

TheCre8r commented 3 years ago

I have since changed the way gas prices are pulled. Will you please verify it still works as intended?

superguru75 commented 3 years ago

Hi. There is an error with the names displayed on the WME for Italian Gas Stations Take this Gas Station as an example.. https://www.waze.com/it/editor?env=row&lon=8.65505&lat=44.90073&zoom=7&venues=5702081.56693130.17984170 https://i.postimg.cc/rsfL9GXc/Prices-for-Italy-Gas-Station.png

You need to correct the displayed names like this: Diesel -> Benzina: €1,349; ‘gas -> Metano: € 0,969 Regular -> Diesel: €1,189 LPG -> GPL: € 0,509 Can you please correct them?

TheCre8r commented 3 years ago

Why is Regular called Diesel and Diesel called Regular?

jm6087 commented 3 years ago

I don't speak Italian but my research shows that Diesel = Gasolio Petro (regular) = Benzina LPG = GPL Natural Gas (gas) = Metano

superguru75 commented 3 years ago

These are the prices for that Gas Station displayed in the app, and all prices shown are correct. In Italy, diesel costs less than petrol. Before your last revision of the script the prices indicated with the modification by Giovanni Cortinovis were displayed correctly in the WME.

Price gas station Spinetta Marengo

jm6087 commented 3 years ago

That is interesting. The background data appears to be different [image: image.png] Ian will have to look into this more closely. Are all stations showing the same thing or is it just this one?

On Sat, Dec 5, 2020 at 5:20 PM superguru75 notifications@github.com wrote:

These are the prices for that Gas Station displayed in the app, and all prices shown are correct. In Italy, diesel costs less than petrol. Before your last revision of the script the prices indicated with the modification by Giovanni Cortinovis were displayed correctly in the WME [image: Price gas station Spinetta Marengo] https://user-images.githubusercontent.com/58091651/101267423-c663a180-3758-11eb-8e85-fe991ae411b6.jpg

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TheCre8r/WME-BackEnd-Data/issues/24#issuecomment-739429342, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6K7LPHD2N2JG5UBRDUDCDSTK53JANCNFSM4NYFKYRA .

superguru75 commented 3 years ago

The prices on the app, are displayed in the same order you see shown on the prices board placed near each Gas Station. The display order you see in the following image is a standard in all Italian Gas Stations. At the top of the list there is always the price of Diesel (Gasolio), in second position there is always the price of Benzina and in third position (if available) the price of GPL and in fourth position (if available) the price of Metano.

price board

jm6087 commented 3 years ago

Thanks and Happy Birthday

On Sun, Dec 6, 2020, 4:00 AM superguru75 notifications@github.com wrote:

The prices on the app, are displayed in the same order you see shown on the prices board placed near each Gas Station. The display order you see in the following image is a standard in all Italian Gas Stations. At the top of the list there is always the price of Diesel (Gasolio), in second position there is always the price of Benzina and in third position (if available) the price of GPL and in fourth position (if available) the price of Metano.

[image: price board] https://user-images.githubusercontent.com/58091651/101277104-35b9af80-37b2-11eb-99a0-4df3ea08d921.jpg

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TheCre8r/WME-BackEnd-Data/issues/24#issuecomment-739480507, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6K7LPGV2A3XXJXH5UPFXLSTNI4LANCNFSM4NYFKYRA .

TheCre8r commented 3 years ago

Thank you for the screen shot in app. The data I am pulling was coded backwards. I have made the flip that @giovanni-cortinovis had created in his fork. I have also made sure the order is sorted accordingly to what it is in app. Please confirm this is working as intended in Version 2020.12.06.01.

Thanks again for the help!

superguru75 commented 3 years ago

Hi. Thanks for your update. Now your script is working correctly. Regards

TheCre8r commented 3 years ago

Thank you for the follow up.