TheDMSGroup / mautic-contact-client

Create custom integrations without writing code, like having your own Zapier.
GNU General Public License v3.0
95 stars 33 forks source link

[ENG-1025] Improve newrelic client error accuracy. #234

Closed heathdutton closed 5 years ago

heathdutton commented 5 years ago

Please be sure you are submitting this against the master branch.

//: # This Pull Request (Place an 'X' for each):

Risk Level No Low High
Alters Lead Data? X
Schema Change? X
Adds A Query or Modifies Existing Query? X
Adds or Modifies Existing Auto-Enhancer? X
Modifies Ingestion Process? X
Modifies sendContact Data? X

Description:

The newrelic provided stats sometimes get a little fuzzy when there's a client error in large quantities. An error with one client appears to affect others, but this is inaccurate, and likely due to how newrelic_add_custom_parameter works under the C code. If we null out values with a string instead of "null" the issue should go away according to one NR support thread. We'll give that a try with the next release, since there's no risk to doing so, and it's a minor change.