TheDan64 / inkwell

It's a New Kind of Wrapper for Exposing LLVM (Safely)
https://thedan64.github.io/inkwell/
Apache License 2.0
2.38k stars 229 forks source link

Upgrade Syn to 2.0 #408

Closed Pat-Lafon closed 1 year ago

Pat-Lafon commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I would like upgrade Inkwell's dependency of Syn to the next major release, 2.0. As other projects have updated, it's quite unfortunate to have 2 versions of Syn in my project dependency tree.

Describe the solution you'd like A clear and concise description of what you want to happen.

I would like to upgrade the Syn version to 2.0 and fix any of the breaking changes. I'll open a pr but the template says I should have an issue first.

Describe possible drawbacks to your solution How might this solution hinder other components or users if implemented?

If some projects are still on Syn 1.0, then they will have multiple versions of Syn in their dependency tree.

Syn still supports a msrv of 1.56 but if this were to increase then that might affect Inkwells minimum version. I'm not 100% sure about how/when this could occur but I'll note it here.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

One could not upgrade but with major crates like clap doing so I'm not sure why one wouldn't.

Additional context Add any other context or screenshots about the feature request here.