search

TheDan64 / inkwell

It's a New Kind of Wrapper for Exposing LLVM (Safely)
https://thedan64.github.io/inkwell/
Apache License 2.0
2.38k stars 229 forks source link

rename `build_bitcast` to `build_bit_cast` #485

Closed Anton-4 closed 7 months ago

Anton-4 commented 8 months ago

Hi, Thanks for working on inkwell :heart:

Can build_bitcast be renamed to build_bit_cast? That would make it more consistent internally with build_int_cast, build_float_cast,... as well as with LLVM's LLVMBuildBitCast.

I can do the PR if desired.

TheDan64 commented 7 months ago

This one is interesting, given that bitcast is a common term and others (ie floatcast) are not. That said, the more consistent naming seems like a good idea