search

TheDataShed / sql-deployment-tools

GNU General Public License v3.0
2 stars 0 forks source link

feat: Extend Pre-Commit #32

Closed gvee-uk closed 2 years ago

gvee-uk commented 2 years ago

Added a number of options to pre-commit, including:

The other changes in this set are fixing issues raised by the new pre-commit hooks (so expect a lot of whitespace changes, for instance!).

github-actions[bot] commented 2 years ago

Unit Test Results

41 tests  ±0   40 :heavy_check_mark: ±0   0s :stopwatch: ±0s   1 suites ±0     1 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 83ff6d4a. ± Comparison against base commit c28f637a.

:recycle: This comment has been updated with latest results.

gvee-uk commented 2 years ago

This will likely be a useful option during the review:

ignore whitespace

GooseLF commented 2 years ago

This PR is running all of the pipelines since I assume you won't have the changes I made to them on Friday. :)

gvee-uk commented 2 years ago

This PR is running all of the pipelines since I assume you won't have the changes I made to them on Friday. :)

This was rebased off main, so should have all-the-changes!

Looks like it's there, to me anyhow: https://github.com/TheDataShed/sql-deployment-tools/blob/extend-pre-commit/.github/workflows/build-executable-windows.yml

GooseLF commented 2 years ago

This PR is running all of the pipelines since I assume you won't have the changes I made to them on Friday. :)

This was rebased off main, so should have all-the-changes!

Looks like it's there, to me anyhow: https://github.com/TheDataShed/sql-deployment-tools/blob/extend-pre-commit/.github/workflows/build-executable-windows.yml

Ignore me! Monday brain. I hate how GitHub displays the checks, it displays each job step as an individual check on the PR rather than just one build. Apologies, I thought for some reason it was running the "release" pipelines still

gvee-uk commented 2 years ago

@GooseLF is it because this CI part stull build on a main PR? https://github.com/TheDataShed/sql-deployment-tools/blob/extend-pre-commit/.github/workflows/sql-deployment-tools-ci.yml#L9

GooseLF commented 2 years ago

Aye, that's what we're after though. I thought it was running the "release" stuff, but it isn't, it's just GitHub's rubbish UI