search

TheDataStation / ver

Data Discovery Tools and Systems
MIT License
5 stars 9 forks source link

view distillation #7

Closed youny626 closed 1 year ago

youny626 commented 1 year ago

All functionality seems concentrated in a utils.py. This is not a very good design. Separate the main logic of the module from the real "utils". I'll take a look at the PR after.

@raulcf I think you are looking at the wrong file. I am not using utils.py(or anything else) from code_used_for_paper/. The new module only uses utils.py and view_distillation.py under the current view_distillation directory. Documentations are in README.

youny626 commented 1 year ago

Closing and create a new PR to exclude files that do not need to be merged.