TheDataStation / ver

Data Discovery Tools and Systems
MIT License
6 stars 10 forks source link

Current Test Suite is Hard to Maintain #74

Open ogiorgil opened 7 months ago

ogiorgil commented 7 months ago
luthfibalaka commented 7 months ago

In PreAnalyzerTest.java, I actually added new tests for spatial patterns in this PR: 75. For legacy tests, I think some of them might not be needed anymore (?)

For AlmostE2ETest.java, I guess it is intended for end-to-end test with external database. Maybe we need to modify it to utilize local database (e.g., in CSV format)?

I also want to add an issue with LabelAnalyzerTest.java, I think there is a problem with the JUnit version. The project uses JUnit 4, while the test presumably uses JUnit 5. Consequently, the test could not be run correctly.

For other tests, should we convert them to unit tests (each test correspond to a certain module) or let them be as is and adapt them to utilize assertion, mock, etc. if needed?

cc: @snowgy