search

TheDatumOrg / kshape-python

Python implementation of k-Shape
MIT License
330 stars 105 forks source link

Default Z-score axis #3

Closed adamgayoso closed 7 years ago

adamgayoso commented 7 years ago

Shouldn't the default be 1? This is how the paper describes the z-normalization.

Mic92 commented 7 years ago

python is zero-indexed, while the authors used matlab where indices begin at 1.

adamgayoso commented 7 years ago

I was more talking about zscoring the raw time series, you would probably zscore each time series, not each time point

Mic92 commented 7 years ago

Indeed, the example code was wrong.