TheDeNuke / DvD-Custom-Branch

This is a radically different branch of the Divergences of Darkness mod that stems off from the final version of PDM's DvD. However any systems from that version would likely be utterly unreconizable due to a rework of practically every single file in the entire mod.
1 stars 1 forks source link

Bug: Decision "Unify with Navarra" has broken OR condition #30

Closed tbg2021 closed 5 years ago

TheDeNuke commented 5 years ago

I had to rework that whole thing so it worked with the other two potential tags, and then bug check it several times.

Turns out I clearly did not bug check it enough.

TheDeNuke commented 5 years ago

Strange. That decisions seems normal and has no issue. Nor is Validator coming up with any issues regarding that decision.

TheDeNuke commented 5 years ago

I removed the "exists = NAV" in the allow since its redundant due to the potential also having "exists = NAV".

Generally it may seem broken but there might also be the factor that if it does not exist and you don't directly own the capital of NAV. The decision will not appear.

TheDeNuke commented 5 years ago

@tbg2021

It... should... work now. Just create another issue if for some reason its still broken.

tbg2021 commented 5 years ago

Nah, it was that in my case as Spain I had just accepted the Catalans and annexed the Basque country as well with my cores already existing, but the decision still available. What the decision in its previous buggy state had let me do in effect was release Navarra as a buffer satellite so the DUA wouldn't immediately curbstomp me, then reincorporate later with no real penalty.

On Fri, Oct 11, 2019 at 10:37 PM TheDeNuke notifications@github.com wrote:

Closed #30 https://github.com/TheDeNuke/DvD-Custom-Branch/issues/30.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TheDeNuke/DvD-Custom-Branch/issues/30?email_source=notifications&email_token=ADMW3C25JZU7L2PZUMKB6YTQOEZ7ZA5CNFSM4JAAJNV2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUFSX5ZY#event-2707783399, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMW3C3MSFB46N6ZAC5TEWDQOEZ7ZANCNFSM4JAAJNVQ .