TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
31 stars 6 forks source link

Small fixes... #1019

Closed AdvancedImagingUTSW closed 6 days ago

AdvancedImagingUTSW commented 6 days ago

configurator - scaled back the warning since it seems to be working nicely.

controller - very small type hinting changes.

camera_view - Extracted some code to make a method that we can call elsewhere. self.get_selected_channels, some typehinting, cleaned up some warnings for things like uncalled parameters (*args), and fixed a few bugs that would occur with the MIP view. Several widgets converted to readonly. Attributes initialized. Edge case handling.

configurator_application_window - make some comboboxes readonly, changed one method name.

display_notebook - made some comboboxes readonly

acquire_popup - made some comboboxes readonly

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 85.07463% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.24%. Comparing base (001fb28) to head (156bef8). Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...navigate/controller/sub_controllers/camera_view.py 85.71% 6 Missing :warning:
...c/navigate/view/configurator_application_window.py 57.14% 3 Missing :warning:
src/navigate/controller/configurator.py 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1019 +/- ## =========================================== + Coverage 54.05% 54.24% +0.18% =========================================== Files 180 180 Lines 20250 20274 +24 =========================================== + Hits 10946 10997 +51 + Misses 9304 9277 -27 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1019/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `54.24% <85.07%> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.