search

TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
31 stars 6 forks source link

Update model.py #885

Closed AdvancedImagingUTSW closed 5 months ago

AdvancedImagingUTSW commented 5 months ago

Check to see if model has attribute signal_container before trying to reset it.

Otherwise, reset the feature list...

Slight refactor to hopefully make the logic more obvious. Please doublecheck.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.07%. Comparing base (91269ab) to head (a999dcb). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #885 +/- ## ======================================== Coverage 51.07% 51.07% ======================================== Files 178 178 Lines 19026 19027 +1 ======================================== + Hits 9717 9718 +1 Misses 9309 9309 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/885/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/885/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `51.07% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AdvancedImagingUTSW commented 5 months ago

Difficult to test since it was a low-frequency error, but everything did seem to run as anticipated.