TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
18 stars 5 forks source link

LUDL Filter Wheel device and AO as a Feature #915

Closed conorhughmcfadden closed 2 months ago

conorhughmcfadden commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 2.08333% with 47 lines in your changes missing coverage. Please review.

Project coverage is 51.43%. Comparing base (3babee7) to head (5982510). Report is 284 commits behind head on develop.

Files Patch % Lines
...te/model/devices/filter_wheel/filter_wheel_ludl.py 0.00% 34 Missing :warning:
src/navigate/model/features/adaptive_optics.py 0.00% 11 Missing :warning:
src/navigate/model/device_startup_functions.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #915 +/- ## =========================================== - Coverage 54.28% 51.43% -2.86% =========================================== Files 154 179 +25 Lines 17489 19109 +1620 =========================================== + Hits 9494 9828 +334 - Misses 7995 9281 +1286 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/915/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/915/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `51.43% <2.08%> (-2.86%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AdvancedImagingUTSW commented 2 months ago

I updated from develop, and committed the updated code to a new branch. Fortunately, I don't think there are any merge conflicts.

AdvancedImagingUTSW commented 2 months ago

Minor changes pushed to pull request #916. Will close this PR and proceed with that one.