search

TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
18 stars 5 forks source link

inherited microscope in configuration #917

Closed annie-xd-wang closed 2 months ago

annie-xd-wang commented 2 months ago

In the configuration.yaml

microscopes: Microscope-1: camera: .... daq: .... Microscope-2 (Microscope-1): ....

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes missing coverage. Please review.

Project coverage is 51.41%. Comparing base (f77ffba) to head (e2b7fbc). Report is 10 commits behind head on develop.

:exclamation: Current head e2b7fbc differs from pull request most recent head 113c6e4

Please upload reports for the commit 113c6e4 to get more accurate results.

Files Patch % Lines
src/navigate/config/config.py 44.82% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #917 +/- ## =========================================== - Coverage 51.41% 51.41% -0.01% =========================================== Files 179 179 Lines 19108 19136 +28 =========================================== + Hits 9824 9838 +14 - Misses 9284 9298 +14 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/917/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/917/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `51.41% <44.82%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AdvancedImagingUTSW commented 2 months ago

Thanks for doing such a careful evaluation, @conorhughmcfadden. We can see what @annie-xd-wang has to say about the things you brought up.

AdvancedImagingUTSW commented 2 months ago

@conorhughmcfadden - Go ahead and submit PR approval and merge it.