Closed AdvancedImagingUTSW closed 1 month ago
When you get back, hopefully this is not too annoying. My goal was to make some of our imports shorter. If you have the pre-commit linter operating, then many of our imports throw errors. We could consider something similar for the sub-controllers. Given that they are in a folder titled sub-controller, having controller in their module names is also redundant.
Tested on CT-ASLM-V2 and BT-MesoSPIM. Works as expected.
Codecov Report
Attention: Patch coverage is
41.93548%
with72 lines
in your changes missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #933 +/- ## =========================================== - Coverage 51.82% 51.80% -0.02% =========================================== Files 179 179 Lines 19091 19093 +2 =========================================== - Hits 9893 9892 -1 - Misses 9198 9201 +3 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/933/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `51.80% <41.93%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.