Closed AdvancedImagingUTSW closed 2 weeks ago
Attention: Patch coverage is 25.24272%
with 77 lines
in your changes missing coverage. Please review.
Project coverage is 53.53%. Comparing base (
1b7e2e9
) to head (6d771eb
). Report is 3 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@annie-xd-wang - Before you do too much work on making the plugins pip installable, could you review and test this PR?
In an attempt to write unit tests for the plugins_model, I found the function load_plugins too large to effectively test. So, I tried to break it up into smaller methods, which could then be tested independently.
Also found duplicated code in the plugins_controller, so I created a method of that section of code, and placed it in config.py. Both the plugins model and the plugins controller now load this function...
Will test before moving on to write unit tests...