search

TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
18 stars 5 forks source link

Rename sub-controllers #940

Closed AdvancedImagingUTSW closed 1 month ago

AdvancedImagingUTSW commented 1 month ago

Again, making an effort to make our imports less insane. Could also consider consolidating sub-controllers by function - e.g., anything that changes the camera view for example, could be in a single module.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 74.28571% with 18 lines in your changes missing coverage. Please review.

Project coverage is 52.98%. Comparing base (ec4cec1) to head (6c581e9).

Files Patch % Lines
...avigate/controller/sub_controllers/waveform_tab.py 9.09% 10 Missing :warning:
...roller/sub_controllers/feature_advanced_setting.py 0.00% 3 Missing :warning:
src/navigate/controller/sub_controllers/plugins.py 33.33% 2 Missing :warning:
...gate/controller/sub_controllers/adaptive_optics.py 50.00% 1 Missing :warning:
...c/navigate/controller/sub_controllers/autofocus.py 50.00% 1 Missing :warning:
...gate/controller/sub_controllers/camera_settings.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #940 +/- ## ======================================== Coverage 52.98% 52.98% ======================================== Files 177 177 Lines 19107 19106 -1 ======================================== Hits 10123 10123 + Misses 8984 8983 -1 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/940/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/940/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `52.98% <74.28%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AdvancedImagingUTSW commented 1 month ago

I believe that everything is working properly, but I figured it wouldn't hurt to have a proper second opinion @annie-xd-wang