TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
31 stars 6 forks source link

Update camera_view.py #986

Closed AdvancedImagingUTSW closed 1 month ago

AdvancedImagingUTSW commented 1 month ago

I'm not 100% sure if the math is performed correctly since it is complicated by the fact that the crosshair is added to the zoom image. But my interpretation is that if the user wants to put the crosshair at position (128, 128) for a 512 x 512 image, then it should stay there when they zoom in.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 74.41860% with 22 lines in your changes missing coverage. Please review.

Project coverage is 53.91%. Comparing base (f8adf9d) to head (2d03b2d). Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
...navigate/controller/sub_controllers/camera_view.py 75.00% 21 Missing :warning:
.../navigate/controller/sub_controllers/keystrokes.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #986 +/- ## ======================================== Coverage 53.90% 53.91% ======================================== Files 178 178 Lines 19521 19555 +34 ======================================== + Hits 10523 10543 +20 - Misses 8998 9012 +14 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/986/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/986/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `53.91% <74.41%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.