TheDeathlyCow / frostiful

A Vanilla+ Snow & Frost Update Survival Experience for Minecraft
GNU Lesser General Public License v3.0
15 stars 8 forks source link

Incompatibility with VanillaIcecreamFix #38

Closed Therkelsen closed 2 months ago

Therkelsen commented 1 year ago

Minecraft v1.20.1 Fabric v0.14.21

Frostiful v0.7 VanillaIceCreamFix v1.1.5

Having Frostiful and VanillaIceCreamFix installed at the same time, at the given versions, causes a crash on startup.

Link to log Link to mod

https://github.com/Therkelsen/echoes_of_the_wilderness/issues/12

TheDeathlyCow commented 1 year ago

Confirmed the incompatibility, seems to be related to a failure to load VanillaIceCreamFix's mixins refmaps. Not sure what the underlying cause is though. May just mark them as incompatible for now.

TheDeathlyCow commented 3 months ago

Ok coming back to this issue. The issue seems to be in Fabric ASM (which Frostiful uses for custom enchantment targets), and not in Frostiful itself. I plan to remove Fabric ASM in 1.20.4+ and to replace it's use with the new Fabric Enchantment API, so this should hopefully be resolved then.