search

TheDeathlyCow / frostiful

A Vanilla+ Snow & Frost Update Survival Experience for Minecraft
GNU Lesser General Public License v3.0
16 stars 8 forks source link

Origins: Umbrellas compat? #87

Closed Exokyhh closed 4 months ago

Exokyhh commented 4 months ago

Describe the bug Equipping an umbrella from the Origins: Umbrellas mod, doesn't prevent you from getting wet.

To Reproduce Steps to reproduce the behavior: 1. /weather rain 2. equip an umbrella 3. check your "wetness" on hotbar

Expected behavior Like the umbrella from the Artifacts mod, not getting wet while the umbrella is equipped ~~under the rain~~

Game information (please complete) - MC Version 1.20.1 - Loader Fabric

Logs I warn you, it's full of shit since I've only installed random mods to test latest.log

Additional context I've already opened an issue on the Origins: Umbrellas github (https://github.com/Fusion-Flux/Origins-Umbrellas/issues/16#issue-2281613557), I'm not sure on which side is the ~~issue, I guess on his side (?), since the mod Artifact has a working as intended umbrella. ~~Though, I wanted you to be aware of this issue. I don't know if you can do some ~~workaround or something similar, you decide. I'm not a mod developer :)~~

(First umbrella is from the Artifacts mod, second one is from the Origins: Umbrellas)

https://github.com/TheDeathlyCow/frostiful/assets/90096585/27fb7aba-d633-488c-8d8b-f1a5de3b28d5

Exokyhh commented 4 months ago

I'm dumb, this issue is about the Scorchful mod, lol, closing it and posting it on the other github