TheDeathlyCow / scorchful

A heat mod for Minecraft Fabric and Quilt. Sister mod to Frostiful.
GNU Lesser General Public License v3.0
5 stars 1 forks source link

[1.20.1] Drinking water doesn't reduce heat or add to the water bar in nether #55

Closed Reshy closed 4 months ago

Reshy commented 4 months ago

Describe the bug Water Skins/Water Bottles aren't refilling the hydration bar, so they don't actually cool you down in the nether.

To Reproduce Steps to reproduce the behavior:

  1. Go to the Nether
  2. Get overheated
  3. Drink Water
  4. Nothing happens.

Expected behavior From the way the game describes it, the water skin and water bottles ought to cool you down, but that doesn't seem to be the case, you also don't passively sweat either in the nether so likely there's a bug with the sweat system. Touching water like from a crimson lily fully saturates your hydration bar but beyond that there's no cooling down besides to lug around some ice blocks. Can't even stand in a cauldron.

Game information (please complete)

Logs N/A

Additional context Starting drinking a water skin: image

Finished drinking the entire waterskin: image

Touch Crimson Lily with a crumb of water dew on it: image

Behavior occurs even when actively dying from heat stroke: image

image

Heat stroke still progresses even when standing in water, no hydration: image image

Only complete submersion in water actually fills the hydration meter: image

TheDeathlyCow commented 4 months ago

Just curious, does this still happen in dark environments? I think the light from that fire may be causing you to dry out before you lose any meaningful amount of temperature.

TheDeathlyCow commented 4 months ago

Going to assume that that was the cause. For now, removing that mechanic (and also made some adjustments to block light heat). Feel free reopen if this issue persists in 0.6.2.

Reshy commented 4 months ago

Seems like it's fixed from my personal testing. Drinking Water, standing in water, etc. increases the water meter like it's supposed to.

One minor issue I noticed, sometimes the water bar will start flickering in and out of the smallest pip. One thing to consider is eliminating temperature build-up while the hydration meter is charging. That way you don't need to sacrifice the heat building mechanic of the nether entirely.