TheDeathlyCow / scorchful

A heat mod for Minecraft Fabric and Quilt. Sister mod to Frostiful.
GNU Lesser General Public License v3.0
5 stars 1 forks source link

[1.20.1] Temperature doesn't naturally lower in neutral environments after warming up #57

Open AStrangeMouse opened 4 months ago

AStrangeMouse commented 4 months ago

On Minecraft 1.20.1 - Latest available version of Scorchful (0.6.2), and all required dependencies, the latest available version of Frostiful (1.0.9) and dependencies, on the current recommended version of Quilt (0.25.0)

Passive temperature does not seem to naturally lower in biomes or areas that are neutral (Thermoo shows 0 for environmental temperature) after gaining any level of warmth.

For example: Standing outside in a Plains biome during the day. After touching fire, or jumping into lava to increase warmth values, those levels of warmth gained never decrease on their own. (Thermoo confirms after checking player temperature via commands, the number never decreases.)

I wasn't certain if this would be considered a bug, or a feature request, so my apologies there.

TheDeathlyCow commented 4 months ago

Thanks for your feedback! This is more or less intentional, not a bug. It is indeed the case that you do not passively lose temperature unless you are in a cold biome and Frostiful is installed. Part of the reason is that trying to have passive cooling in Scorchful (and passive warming in Frostiful) led to some nightmarish compatibility issues that were very difficult to work out - and ultimately I just decided to axe these features. Another reason, perhaps a bit weaker, is that the Thermoo temperature system used in Scorchful is more or less an extension of powder snow freezing ticks. That is, your temperature is really just a measure of how long you have been exposed to the elements. It is not the same as the usual 'body temperature' you might measure with a thermometer when you have a fever, for example. So the idea that the environment is cooler than your body is, is difficult to measure.

I can try some things out, and get back to you. In the mean time, the usual means of cooling (sweating, swimming, standing on ice, falling in powder snow, etc) are the only way to cool off in these neutral biomes.

As a side note, I do find it interesting that this issue has never been raised in Frostiful. Possibly because the primary means of heating (torches) are so fundamental to normal Minecraft gameplay that this isn't really an issue, whereas swimming and sweating require you to sidetrack a bit more.

AStrangeMouse commented 4 months ago

Fair enough! If you do end up wanting to try something else out, I would definitely be interested in seeing what you come up with.

And yeah - I could definitely see that (with Frostiful) as being the reason why. Personally my own reason was that I hadn't gotten around to checking the cold aspects yet, as I was testing the heating side of things first for my personal modpack, then I came here because I wasn't sure.

TheDeathlyCow commented 4 months ago

I might try adding something where neutral biomes cool the player off a little bit, but not all the way. Just enough to bring you back from the brink of death, but not enough to clear all the effects of heat stroke.

Reshy commented 4 months ago

Maybe it'd be possible to assign temperatures based on the type of biome, and that temperature is how much it can passively heat or cool you to? Eg. a Desert can heat you to 10 pips (heastroke range), a rainforest can heat you to let's say 6 pips, plains is 0 pips, a tundra may be like -6 pips, and an ice spires biome being like -10 pips?

TheDeathlyCow commented 4 months ago

Negative temperatures are already handled in Frostiful, so tundra and ice spikes is already covered there :p But that doesn't solve the original issue here that if you are already warm, entering into a neutral biome like plains does not help improve your condition at all (though it also does not make it any worse).

Reshy commented 4 months ago

An environment can't be assigned a max temperature for it to heat or cool you to when outside of that range?